[scielo-tools-17] App standalone spsvalidator#15
Closed
gitnnolabs wants to merge 1 commit into
Closed
Conversation
…ação de pacote SPS App auto-suficiente em apps/spsvalidator (Flask + Pywebview + SQLite + packtools) para validação de pacotes SPS (.zip), isolado do projeto Django principal e sem depender de Celery. Inclui modo desktop (Pywebview) e modo navegador (Flask), export CSV dos resultados, persistência local em SQLite e scripts de empacotamento por sistema operacional (macOS, Linux, Windows).
robertatakenaka
requested review from
samuelveigarangel
and removed request for
Rossi-Luciano
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| from packtools.sps.pid_provider.xml_sps_lib import XMLWithPre | ||
| from packtools.sps.validation.xml_validator import get_validation_results | ||
|
|
||
| if not os.path.isfile(zip_path): |
|
|
||
| def _sha256_of_file(path: str) -> str: | ||
| digest = hashlib.sha256() | ||
| with open(path, "rb") as file_pointer: |
| raise ValueError(zip_only_message or "Only SPS .zip files are supported.") | ||
| with tempfile.TemporaryDirectory(prefix="spsvalidator-") as temp_dir: | ||
| zip_path = os.path.join(temp_dir, Path(filename).name) | ||
| uploaded_file.save(zip_path) |
| filename = "package.zip" | ||
|
|
||
| def save(self, destination): | ||
| Path(destination).write_bytes(b"zip") |
| filename = "package.zip" | ||
|
|
||
| def save(self, destination): | ||
| Path(destination).write_bytes(payload.getvalue()) |
| def _redirect_with_lang(endpoint: str, **values): | ||
| response = make_response(redirect(url_for(endpoint, **values))) | ||
| language = normalize_language(request.cookies.get("lang")) | ||
| response.set_cookie("lang", language, max_age=60 * 60 * 24 * 365) |
| def set_language(language_code: str): | ||
| language = normalize_language(language_code) | ||
| redirect_target = request.args.get("next") or url_for("web.index") | ||
| response = make_response(redirect(redirect_target)) |
gitnnolabs
changed the title
Member
|
branch migrado para um repositório: spsvalidator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que esse PR faz?
Adiciona o app standalone
apps/spsvalidator: uma aplicação auto-suficiente para validação de pacotes SPS (.zip), independente do projeto Django/Wagtail principal e sem Celery. Características:pyproject.tomlpróprio, layoutsrc/).spsvalidator --browser, emhttp://127.0.0.1:5000)..zip, validação via packtools, export CSV dos resultados e persistência local do histórico em SQLite (~/.spsvalidator/spsvalidator.sqlite3).web/i18n.py) e API desktop (desktop_api.py).packaging/(macOS/Linux/Windows) +spsvalidator.spec(PyInstaller).Onde a revisão poderia começar?
apps/spsvalidator/src/spsvalidator/domain/validation.py(núcleo da validação do pacote)apps/spsvalidator/src/spsvalidator/services/validation_service.py(orquestração + persistência)apps/spsvalidator/src/spsvalidator/web/routes.pyeapp.py(camada web/Flask)apps/spsvalidator/src/spsvalidator/main.py(entrypoint desktop/navegador)apps/spsvalidator/pyproject.toml(dependências e scriptspsvalidator)Como este poderia ser testado manualmente?
cd apps/spsvalidatorpython -m venv .venv && source .venv/bin/activatepip install -e ".[dev]"python -m pytest -qspsvalidator --browsere abrirhttp://127.0.0.1:5000.zipSPS pela interface e conferir o resultado da validação e o export CSV.Algum cenário de contexto que queira dar?
O
spsvalidatoré entregue como app isolado/auto-suficiente (não roda como task e não acopla ao Django principal), complementando a validação integrada ao Wagtail (xml_manager) para o cenário desktop/offline.Pontos de atenção para a revisão (ajustar antes do merge, se aplicável):
apps/spsvalidator/src/spsvalidator.egg-info/— artefato de build que normalmente não deve ser versionado (sugeridogit rm -r --cachede adicionar*.egg-info/ao.gitignore).test_metadata.py,test_service_and_web.pyetest_validation_integration.pydependem de uma fixture XML; confirmar queapps/spsvalidator/tests/fixtures/dias_2023.xmlestá incluída no PR para que os testes rodem de forma isolada.Screenshots
N/A
Quais são tickets relevantes?
scieloorg/spsvalidator#5
Referências
packtools4.12.6 (scieloorg/packtools)scielo-tools-initial/apps/spsvalidator